linux-kernel - Re: [PATCH 1/2] lis3lv02d: Fix read() call in lis3lv02d_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110906140735.68ddbf42.akpm@linux-foundation.org>
Date:	Tue, 6 Sep 2011 14:07:35 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Éric Piel <eric.piel@...mplin-utc.net>,
	Ilkka Koskinen <ilkka.koskinen@...ia.com>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 1/2] lis3lv02d: Fix read() call in lis3lv02d_get_odr()

On Tue,  6 Sep 2011 00:12:28 -0700
Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> The driver is passing a struct lis3lv02d ** to the read() operation but
> the read() operation wants a struct lis3lv02d * causing compiler warnings
> and presumably also runtime problems.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> Cc: stable@...nel.org
> ---
>  drivers/misc/lis3lv02d/lis3lv02d.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c
> index e67dcea..72a1f92 100644
> --- a/drivers/misc/lis3lv02d/lis3lv02d.c
> +++ b/drivers/misc/lis3lv02d/lis3lv02d.c
> @@ -200,7 +200,7 @@ static int lis3lv02d_get_odr(struct lis3lv02d *lis3)
>  	u8 ctrl;
>  	int shift;
>  
> -	lis3->read(&lis3, CTRL_REG1, &ctrl);
> +	lis3->read(lis3, CTRL_REG1, &ctrl);
>  	ctrl &= lis3->odr_mask;
>  	shift = ffs(lis3->odr_mask) - 1;
>  	return lis3->odrs[(ctrl >> shift)];

This not applicable to mainline or to -stable.  It is a fix to
lis3-remove-the-references-to-the-global-variable-in-core-driver.patch
which I already have queued, as
lis3-remove-the-references-to-the-global-variable-in-core-driver-fix.patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/