linux-kernel - Re: [PATCH v3 2/2] xen: modify kernel mappings corresponding to granted pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E67C06E.1030905@goop.org>
Date:	Wed, 07 Sep 2011 12:05:18 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
CC:	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	Ian Campbell <Ian.Campbell@...citrix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>
Subject: Re: [PATCH v3 2/2] xen: modify kernel mappings corresponding to granted
 pages

On 09/07/2011 10:38 AM, Stefano Stabellini wrote:
>
>> But also, this pattern of getting results back from batched calls is
>> unusual - actually, I think this is unique.  If you have batched up a
>> map operation which has its map_op args allocated from the multicall
>> buffer, then the flush will implicitly free them as well, so it isn't
>> valid to read back from the structure later on.  If you want to have an
>> args structure you can use once the hypercall has been issued, you need
>> to manually manage its lifetime.
> But I am not using the multicall buffer as argument, I am using the
> kmap_op passed to m2p_add_override.

Yep, I overlooked that.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/