linux-kernel - Re: [PATCH] Simplify PTRACE_foo constants and PTRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK1hOcMmwbSuDA2g4Tt7EO6sqjq-n-URTnMbr7RszqkMcs5jEA@mail.gmail.com>
Date:	Thu, 8 Sep 2011 14:13:22 +0200
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code

On Thu, Sep 8, 2011 at 2:06 AM, Tejun Heo <tj@...nel.org> wrote:
> Hello,
>
> Mostly looks good to me.  Just a small nit.
>
> On Wed, Sep 07, 2011 at 11:36:37PM +0200, Denys Vlasenko wrote:
>>  static int ptrace_setoptions(struct task_struct *child, unsigned long data)
>>  {
>> +     unsigned flags;
>>
>> +     if (data & ~(long)PTRACE_O_MASK) {
>
> Can we use (unsigned long) here?  Signed extensions have a nasty way
> of sneaking up on you.

Ok.

>> +             child->ptrace &= ~PT_TRACE_MASK; /* historical bug */
>
> And it would be great if it explains what the historical bug was and
> what the intended behavior is.

I'd rather nuke the bug in a follow-up patch (by deleting this line).

-- 
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/