linux-kernel - Re: [PATCH] Simplify PTRACE_foo constants and PTRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110908000614.GA3987@mtj.dyndns.org>
Date:	Thu, 8 Sep 2011 09:06:14 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code

Hello,

Mostly looks good to me.  Just a small nit.

On Wed, Sep 07, 2011 at 11:36:37PM +0200, Denys Vlasenko wrote:
>  static int ptrace_setoptions(struct task_struct *child, unsigned long data)
>  {
> +	unsigned flags;
>  
> +	if (data & ~(long)PTRACE_O_MASK) {

Can we use (unsigned long) here?  Signed extensions have a nasty way
of sneaking up on you.

> +		child->ptrace &= ~PT_TRACE_MASK; /* historical bug */

And it would be great if it explains what the historical bug was and
what the intended behavior is.

Other than that,

 Acked-by: Tejun Heo <tj@...nel.org>

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/