linux-kernel - Re: [patch v3 30/36] Hexagon: Add page-fault support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110913013429.GE6925@codeaurora.org>
Date:	Mon, 12 Sep 2011 20:34:29 -0500
From:	Richard Kuo <rkuo@...eaurora.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linux-arch@...r.kernel.org, linux-hexagon@...r.kernel.org,
	linux-kernel@...r.kernel.org, Linas Vepstas <linas@...eaurora.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [patch v3 30/36] Hexagon: Add page-fault support.

On Sun, Sep 11, 2011 at 12:08:49PM -0300, Benjamin Herrenschmidt wrote:
> Are you sure about enabling interrupts before going to "no_context" ?
> 
> If somebody does a user access "in atomic" with interrupt disabled (with
> the expectation that a fault would be caught by search_exception_tables
> and returned as -EFAULT), such code probably doesn't expect interrupts
> to be re-enabled implicitely.

I hadn't considered that...  I'll review this and make sure this isn't what
we intended (it probably isn't) and get it fixed.


Thanks,
Richard Kuo


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/