| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAErSpo55KB7Gwc26=zm0kJozsjQcdtG+PQFYFd4v1V8mT7gEoA@mail.gmail.com>
Date: Tue, 13 Sep 2011 10:25:20 -0600
From: Bjorn Helgaas <bhelgaas@...gle.com>
To: Witold Szczeponik <Witold.Szczeponik@....net>
Cc: "Dr. David Alan Gilbert" <linux@...blig.org>,
linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] PNPACPI: Simplify disabled resource registration
On Thu, Jun 9, 2011 at 1:03 PM, Witold Szczeponik
<Witold.Szczeponik@....net> wrote:
> The attached patch simplifies 29df8d8f8702f0f53c1375015f09f04bc8d023c1. As
> the "pnp_xxx" structs are not designed to cope with IORESOURCE_DISABLED, and
> hence no code can test for this value, setting this value is actually a "no op"
> and can be skipped altogether. It is sufficient to remove the checks for
> "empty" resources and continue processing.
>
>
> Signed-off-by: Witold Szczeponik <Witold.Szczeponik@....net>
Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
I think keeping all the resources is the right thing because we need
them for _SRS templates, as you mentioned.
Len normally takes PNP patches through his ACPI tree.
>
>
> diff -u linux/drivers/pnp/pnpacpi/rsparser.c linux/drivers/pnp/pnpacpi/rsparser.c
> --- linux/drivers/pnp/pnpacpi/rsparser.c
> +++ linux/drivers/pnp/pnpacpi/rsparser.c
> @@ -509,15 +509,12 @@
> struct acpi_resource_dma *p)
> {
> int i;
> - unsigned char map = 0, flags = 0;
> -
> - if (p->channel_count == 0)
> - flags |= IORESOURCE_DISABLED;
> + unsigned char map = 0, flags;
>
> for (i = 0; i < p->channel_count; i++)
> map |= 1 << p->channels[i];
>
> - flags |= dma_flags(dev, p->type, p->bus_master, p->transfer);
> + flags = dma_flags(dev, p->type, p->bus_master, p->transfer);
> pnp_register_dma_resource(dev, option_flags, map, flags);
> }
>
> @@ -527,17 +524,14 @@
> {
> int i;
> pnp_irq_mask_t map;
> - unsigned char flags = 0;
> -
> - if (p->interrupt_count == 0)
> - flags |= IORESOURCE_DISABLED;
> + unsigned char flags;
>
> bitmap_zero(map.bits, PNP_IRQ_NR);
> for (i = 0; i < p->interrupt_count; i++)
> if (p->interrupts[i])
> __set_bit(p->interrupts[i], map.bits);
>
> - flags |= irq_flags(p->triggering, p->polarity, p->sharable);
> + flags = irq_flags(p->triggering, p->polarity, p->sharable);
> pnp_register_irq_resource(dev, option_flags, &map, flags);
> }
>
> @@ -547,10 +541,7 @@
> {
> int i;
> pnp_irq_mask_t map;
> - unsigned char flags = 0;
> -
> - if (p->interrupt_count == 0)
> - flags |= IORESOURCE_DISABLED;
> + unsigned char flags;
>
> bitmap_zero(map.bits, PNP_IRQ_NR);
> for (i = 0; i < p->interrupt_count; i++) {
> @@ -564,7 +555,7 @@
> }
> }
>
> - flags |= irq_flags(p->triggering, p->polarity, p->sharable);
> + flags = irq_flags(p->triggering, p->polarity, p->sharable);
> pnp_register_irq_resource(dev, option_flags, &map, flags);
> }
>
> @@ -574,11 +565,8 @@
> {
> unsigned char flags = 0;
>
> - if (io->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> if (io->io_decode == ACPI_DECODE_16)
> - flags |= IORESOURCE_IO_16BIT_ADDR;
> + flags = IORESOURCE_IO_16BIT_ADDR;
> pnp_register_port_resource(dev, option_flags, io->minimum, io->maximum,
> io->alignment, io->address_length, flags);
> }
> @@ -587,13 +575,8 @@
> unsigned int option_flags,
> struct acpi_resource_fixed_io *io)
> {
> - unsigned char flags = 0;
> -
> - if (io->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> pnp_register_port_resource(dev, option_flags, io->address, io->address,
> - 0, io->address_length, flags | IORESOURCE_IO_FIXED);
> + 0, io->address_length, IORESOURCE_IO_FIXED);
> }
>
> static __init void pnpacpi_parse_mem24_option(struct pnp_dev *dev,
> @@ -602,11 +585,8 @@
> {
> unsigned char flags = 0;
>
> - if (p->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> if (p->write_protect == ACPI_READ_WRITE_MEMORY)
> - flags |= IORESOURCE_MEM_WRITEABLE;
> + flags = IORESOURCE_MEM_WRITEABLE;
> pnp_register_mem_resource(dev, option_flags, p->minimum, p->maximum,
> p->alignment, p->address_length, flags);
> }
> @@ -617,11 +597,8 @@
> {
> unsigned char flags = 0;
>
> - if (p->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> if (p->write_protect == ACPI_READ_WRITE_MEMORY)
> - flags |= IORESOURCE_MEM_WRITEABLE;
> + flags = IORESOURCE_MEM_WRITEABLE;
> pnp_register_mem_resource(dev, option_flags, p->minimum, p->maximum,
> p->alignment, p->address_length, flags);
> }
> @@ -632,11 +609,8 @@
> {
> unsigned char flags = 0;
>
> - if (p->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> if (p->write_protect == ACPI_READ_WRITE_MEMORY)
> - flags |= IORESOURCE_MEM_WRITEABLE;
> + flags = IORESOURCE_MEM_WRITEABLE;
> pnp_register_mem_resource(dev, option_flags, p->address, p->address,
> 0, p->address_length, flags);
> }
> @@ -656,19 +630,16 @@
> return;
> }
>
> - if (p->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> if (p->resource_type == ACPI_MEMORY_RANGE) {
> if (p->info.mem.write_protect == ACPI_READ_WRITE_MEMORY)
> - flags |= IORESOURCE_MEM_WRITEABLE;
> + flags = IORESOURCE_MEM_WRITEABLE;
> pnp_register_mem_resource(dev, option_flags, p->minimum,
> p->minimum, 0, p->address_length,
> flags);
> } else if (p->resource_type == ACPI_IO_RANGE)
> pnp_register_port_resource(dev, option_flags, p->minimum,
> p->minimum, 0, p->address_length,
> - flags | IORESOURCE_IO_FIXED);
> + IORESOURCE_IO_FIXED);
> }
>
> static __init void pnpacpi_parse_ext_address_option(struct pnp_dev *dev,
> @@ -678,19 +649,16 @@
> struct acpi_resource_extended_address64 *p = &r->data.ext_address64;
> unsigned char flags = 0;
>
> - if (p->address_length == 0)
> - flags |= IORESOURCE_DISABLED;
> -
> if (p->resource_type == ACPI_MEMORY_RANGE) {
> if (p->info.mem.write_protect == ACPI_READ_WRITE_MEMORY)
> - flags |= IORESOURCE_MEM_WRITEABLE;
> + flags = IORESOURCE_MEM_WRITEABLE;
> pnp_register_mem_resource(dev, option_flags, p->minimum,
> p->minimum, 0, p->address_length,
> flags);
> } else if (p->resource_type == ACPI_IO_RANGE)
> pnp_register_port_resource(dev, option_flags, p->minimum,
> p->minimum, 0, p->address_length,
> - flags | IORESOURCE_IO_FIXED);
> + IORESOURCE_IO_FIXED);
> }
>
> struct acpipnp_parse_option_s {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists