linux-kernel - Re: [PATCH 0/2] PCI: PCI-E MPS bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1315950979.455.159.camel@pasglop>
Date:	Tue, 13 Sep 2011 18:56:19 -0300
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Jon Mason <mason@...i.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 0/2] PCI: PCI-E MPS bug fixes


> DNS issue with kernel.org when the patches went out caused it to not
> get out to any of the mailing lists.
> 
> In Linux' github tree
> Patch 1/2 is commit 5307f6d5fb12fd01f9f321bc4a8fd77e74858647
> Patch 2/2 is commit ed2888e906b56769b4ffabb9c577190438aa68b8
> 
> > When using "safe" mode, I get a crash in pcie_find_smpss(). Patch below.
> >
> > From 1b542d690323fab332e61099193d598c5c515d13 Mon Sep 17 00:00:00 2001
> > From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> > Date: Tue, 13 Sep 2011 15:16:33 -0300
> > Subject: [PATCH] pci: Don't crash when reading mpss from root complex
> >
> > In pcie_find_smpss(), we have the following statement:
> >
> >        if (dev->is_hotplug_bridge && (!list_is_singular(&dev->bus->devices) ||
> >            dev->bus->self->pcie_type != PCI_EXP_TYPE_ROOT_PORT))
> >
> > The problem is that at least on my machine, this gets called for the
> > root complex (virtual P2P bridge), and dev->bus->self is NULL since
> > the parent bus for this is not itself anchor to a PCI device.
> >
> > This adds the necessary NULL check.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> 
> Good catch.
> 
> Acked-by: Jon Mason <mason@...i.com>

Linus, please apply.

Cheers
Ben.

> > ---
> >  drivers/pci/probe.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> > index 8473727..09d1c0f 100644
> > --- a/drivers/pci/probe.c
> > +++ b/drivers/pci/probe.c
> > @@ -1351,7 +1351,8 @@ static int pcie_find_smpss(struct pci_dev *dev, void *data)
> >         * will occur as normal.
> >         */
> >        if (dev->is_hotplug_bridge && (!list_is_singular(&dev->bus->devices) ||
> > -           dev->bus->self->pcie_type != PCI_EXP_TYPE_ROOT_PORT))
> > +            (dev->bus->self &&
> > +             dev->bus->self->pcie_type != PCI_EXP_TYPE_ROOT_PORT)))
> >                *smpss = 0;
> >
> >        if (*smpss > dev->pcie_mpss)
> > --
> > 1.7.4.1
> >
> >
> >
> >
> >
> >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/