linux-kernel - Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not declared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110913215851.GD9560@google.com>
Date:	Tue, 13 Sep 2011 14:58:51 -0700
From:	msb@...gle.com
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Herbert Xu <herbert@...dor.hengli.com.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not
 declared

+cc linux-crypto, herbert, davem, torvalds

H Hartley Sweeten (hartleys@...ionengravers.com) wrote:
> Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> and sha_init to quite the sparse noise:
> 
> warning: symbol 'sha_transform' was not declared. Should it be static?
> warning: symbol 'sha_init' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Mandeep Singh Baines <msb@...omium.org>
> 

Acked-by: Mandeep Singh Baines <msb@...omium.org>

Thanks.

> ---
> 
> diff --git a/lib/sha1.c b/lib/sha1.c
> index f33271d..1de509a 100644
> --- a/lib/sha1.c
> +++ b/lib/sha1.c
> @@ -8,6 +8,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/bitops.h>
> +#include <linux/cryptohash.h>
>  #include <asm/unaligned.h>
>  
>  /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/