| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1316017900-19918-4-git-send-email-robherring2@gmail.com>
Date: Wed, 14 Sep 2011 11:31:38 -0500
From: Rob Herring <robherring2@...il.com>
To: linux-arm-kernel@...ts.infradead.org,
devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc: grant.likely@...retlab.ca, marc.zyngier@....com,
thomas.abraham@...aro.org, jamie@...ieiles.com, b-cousson@...com,
shawn.guo@...aro.org, Rob Herring <rob.herring@...xeda.com>
Subject: [PATCH 3/5] of/irq: introduce of_irq_init
From: Rob Herring <rob.herring@...xeda.com>
of_irq_init will scan the devicetree for matching interrupt controller
nodes. Then it calls an initialization function for each found controller
in the proper order with parent nodes initialized before child nodes.
Based on initial pseudo code from Grant Likely.
Signed-off-by: Rob Herring <rob.herring@...xeda.com>
Cc: Grant Likely <grant.likely@...retlab.ca>
---
drivers/of/irq.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++
include/linux/of_irq.h | 1 +
2 files changed, 97 insertions(+), 0 deletions(-)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 9f689f1..a0cd7e8 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -19,10 +19,13 @@
*/
#include <linux/errno.h>
+#include <linux/list.h>
+#include <linux/list_sort.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_irq.h>
#include <linux/string.h>
+#include <linux/slab.h>
/* For archs that don't support NO_IRQ (such as x86), provide a dummy value */
#ifndef NO_IRQ
@@ -386,3 +389,96 @@ int of_irq_to_resource_table(struct device_node *dev, struct resource *res,
return i;
}
+
+struct intc_desc {
+ struct list_head list;
+ struct device_node *dev;
+ struct device_node *parent;
+};
+
+typedef void (*irq_init_cb_t)(struct device_node *, struct device_node *);
+
+static int __init irq_cmp_intc_desc(void *unused, struct list_head *a,
+ struct list_head *b)
+{
+ const struct intc_desc *da = list_entry(a, typeof(*da), list);
+ const struct intc_desc *db = list_entry(b, typeof(*db), list);
+
+ /* same parent, so order doesn't matter */
+ if (da->parent == db->parent)
+ return 0;
+
+ /* NULL parent comes first */
+ if (!da->parent && db->parent)
+ return -1;
+ if (!db->parent && da->parent)
+ return 1;
+
+ /* parent node must be before child node */
+ if (da->dev == db->parent)
+ return -1;
+ if (db->dev == da->parent)
+ return 1;
+
+ return 0;
+}
+
+/**
+ * of_irq_init - Scan the device tree for matching interrupt controllers and
+ * call their initialization functions in order with parents first.
+ * @matches: 0 terminated array of nodes to match and initialization function
+ * to call on match
+ */
+void __init of_irq_init(const struct of_device_id *matches)
+{
+ struct device_node *np;
+ const struct of_device_id *match;
+ struct intc_desc *desc;
+ struct intc_desc *temp_desc;
+ struct list_head intc_desc_list;
+
+ INIT_LIST_HEAD(&intc_desc_list);
+
+ for_each_matching_node(np, matches) {
+ if (!of_find_property(np, "interrupt-controller", NULL))
+ continue;
+ /* Here, we allocate and populate an intc_desc with the node
+ * pointer, interrupt-parent device_node etc. */
+ desc = kzalloc(sizeof(*desc), GFP_KERNEL);
+ if (!desc) {
+ WARN_ON(1);
+ goto err;
+ }
+ desc->dev = np;
+ desc->parent = of_irq_find_parent(np);
+ list_add(&desc->list, &intc_desc_list);
+ }
+ if (list_empty(&intc_desc_list))
+ return;
+
+ /*
+ * The root irq controller is the one without an interrupt-parent.
+ * That one goes first, followed by the controllers that reference it,
+ * followed by the ones that reference the 2nd level controllers, etc
+ */
+ list_sort(NULL, &intc_desc_list, irq_cmp_intc_desc);
+
+ list_for_each_entry_safe(desc, temp_desc, &intc_desc_list, list) {
+ match = of_match_node(matches, desc->dev);
+ if (match && match->data) {
+ irq_init_cb_t irq_init_cb = match->data;
+ pr_debug("of_irq_init: init %s @ %p, parent %p\n",
+ match->compatible, desc->dev, desc->parent);
+ irq_init_cb(desc->dev, desc->parent);
+ }
+ list_del(&desc->list);
+ kfree(desc);
+ }
+ return;
+
+err:
+ list_for_each_entry_safe(desc, temp_desc, &intc_desc_list, list) {
+ list_del(&desc->list);
+ kfree(desc);
+ }
+}
diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
index cd2e61c..032d76c 100644
--- a/include/linux/of_irq.h
+++ b/include/linux/of_irq.h
@@ -73,6 +73,7 @@ extern int of_irq_to_resource_table(struct device_node *dev,
struct resource *res, int nr_irqs);
extern struct device_node *of_irq_find_parent(struct device_node *child);
+extern void of_irq_init(const struct of_device_id *matches);
#endif /* CONFIG_OF_IRQ */
#endif /* CONFIG_OF */
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists