linux-kernel - Re: [PATCH] staging: zcache: fix cleancache crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC9WiBiHZ8jSBRaFQdsk-DwaNLFyR=e0zWUgrNEu6mE0ZoS0vQ@mail.gmail.com>
Date:	Wed, 14 Sep 2011 23:02:45 +0200
From:	Francis Moreau <francis.moro@...il.com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	Seth Jennings <sjenning@...ux.vnet.ibm.com>, gregkh@...e.de,
	devel@...verdev.osuosl.org, linux-mm@...ck.org, ngupta@...are.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: zcache: fix cleancache crash

On Wed, Sep 14, 2011 at 11:26 AM, Francis Moreau <francis.moro@...il.com> wrote:
> On Tue, Sep 13, 2011 at 10:56 PM, Dan Magenheimer
> <dan.magenheimer@...cle.com> wrote:
>>> From: Seth Jennings [mailto:sjenning@...ux.vnet.ibm.com]
>>> Sent: Tuesday, September 13, 2011 1:19 PM
>>> To: gregkh@...e.de
>>> Cc: devel@...verdev.osuosl.org; linux-mm@...ck.org; ngupta@...are.org; linux-kernel@...r.kernel.org;
>>> francis.moro@...il.com; Dan Magenheimer; Seth Jennings
>>> Subject: [PATCH] staging: zcache: fix cleancache crash
>>>
>>> After commit, c5f5c4db, cleancache crashes on the first
>>> successful get. This was caused by a remaining virt_to_page()
>>> call in zcache_pampd_get_data_and_free() that only gets
>>> run in the cleancache path.
>>>
>>> The patch converts the virt_to_page() to struct page
>>> casting like was done for other instances in c5f5c4db.
>>>
>>> Based on 3.1-rc4
>>>
>>> Signed-off-by: Seth Jennings <sjenning@...ux.vnet.ibm.com>
>>
>> Yep, this appears to fix it!  Hopefully Francis can confirm.
>
> Ok I can give this a try and let you know.

This patch has fixed the issue I was hitting with qemu.

Thanks
-- 
Francis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/