linux-kernel - RE: [PATCH] staging: zcache: fix cleancache crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cb0f464-7e39-4294-9f98-c4c5a66110ba@default>
Date:	Thu, 15 Sep 2011 07:16:10 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	gregkh@...e.de
Cc:	devel@...verdev.osuosl.org, linux-mm@...ck.org, ngupta@...are.org,
	linux-kernel@...r.kernel.org, francis.moro@...il.com,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Subject: RE: [PATCH] staging: zcache: fix cleancache crash

> From: Dan Magenheimer
> Sent: Tuesday, September 13, 2011 2:56 PM
> To: Seth Jennings; gregkh@...e.de
> Cc: devel@...verdev.osuosl.org; linux-mm@...ck.org; ngupta@...are.org; linux-kernel@...r.kernel.org;
> francis.moro@...il.com
> Subject: RE: [PATCH] staging: zcache: fix cleancache crash
> 
> > From: Seth Jennings [mailto:sjenning@...ux.vnet.ibm.com]
> > Sent: Tuesday, September 13, 2011 1:19 PM
> > To: gregkh@...e.de
> > Cc: devel@...verdev.osuosl.org; linux-mm@...ck.org; ngupta@...are.org; linux-kernel@...r.kernel.org;
> > francis.moro@...il.com; Dan Magenheimer; Seth Jennings
> > Subject: [PATCH] staging: zcache: fix cleancache crash
> >
> > After commit, c5f5c4db, cleancache crashes on the first
> > successful get. This was caused by a remaining virt_to_page()
> > call in zcache_pampd_get_data_and_free() that only gets
> > run in the cleancache path.
> >
> > The patch converts the virt_to_page() to struct page
> > casting like was done for other instances in c5f5c4db.
> >
> > Based on 3.1-rc4
> >
> > Signed-off-by: Seth Jennings <sjenning@...ux.vnet.ibm.com>
> 
> Yep, this appears to fix it!  Hopefully Francis can confirm.
> 
> Greg, ideally apply this additional fix rather than do the revert
> of the original patch suggested in https://lkml.org/lkml/2011/9/13/234
> 
> Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>


Greg, Francis has confirmed offlist that Seth's fix below
has fixed his issue as well.  Please apply, hopefully as
soon as possible and before 3.1 goes final!

Thanks,
Dan

 
> > ---
> >  drivers/staging/zcache/zcache-main.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> > index a3f5162..462fbc2 100644
> > --- a/drivers/staging/zcache/zcache-main.c
> > +++ b/drivers/staging/zcache/zcache-main.c
> > @@ -1242,7 +1242,7 @@ static int zcache_pampd_get_data_and_free(char *data, size_t *bufsize, bool
> raw,
> >  	int ret = 0;
> >
> >  	BUG_ON(!is_ephemeral(pool));
> > -	zbud_decompress(virt_to_page(data), pampd);
> > +	zbud_decompress((struct page *)(data), pampd);
> >  	zbud_free_and_delist((struct zbud_hdr *)pampd);
> >  	atomic_dec(&zcache_curr_eph_pampd_count);
> >  	return ret;
> > --
> > 1.7.4.1
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/