linux-kernel - Re: [PATCH 37/57] mmc: irq: Remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1109211208440.24024@axis700.grange>
Date:	Wed, 21 Sep 2011 12:16:06 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Yong Zhang <yong.zhang0@...il.com>
cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, Chris Ball <cjb@...top.org>,
	Ian Molton <ian@...menth.co.uk>,
	Tony Lindgren <tony@...mide.com>,
	Kishore Kadiyala <kishore.kadiyala@...com>,
	Adrian Hunter <adrian.hunter@...ia.com>,
	Balaji T K <balajitk@...com>, linux-omap@...r.kernel.org,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH 37/57] mmc: irq: Remove IRQF_DISABLED

On Wed, 21 Sep 2011, Yong Zhang wrote:

> Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
> We run all interrupt handlers with interrupts disabled
> and we even check and yell when an interrupt handler
> returns with interrupts enabled (see commit [b738a50a:
> genirq: Warn when handler enables interrupts]).
> 
> So now this flag is a NOOP and can be removed.
> 
> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
> ---
>  drivers/mmc/host/omap_hsmmc.c |    5 ++---
>  drivers/mmc/host/tmio_mmc.c   |    4 ++--

For tmio_mmc.c:

Acked-by: Guennadi Liakhovetski <g.liakhovetski@....de>

Thanks
Guennadi

>  2 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 21e4a79..75c6395 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2015,7 +2015,7 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Request IRQ for MMC operations */
> -	ret = request_irq(host->irq, omap_hsmmc_irq, IRQF_DISABLED,
> +	ret = request_irq(host->irq, omap_hsmmc_irq, 0,
>  			mmc_hostname(mmc), host);
>  	if (ret) {
>  		dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
> @@ -2043,8 +2043,7 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
>  	if ((mmc_slot(host).card_detect_irq)) {
>  		ret = request_irq(mmc_slot(host).card_detect_irq,
>  				  omap_hsmmc_cd_handler,
> -				  IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING
> -					  | IRQF_DISABLED,
> +				  IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
>  				  mmc_hostname(mmc), host);
>  		if (ret) {
>  			dev_dbg(mmc_dev(host->mmc),
> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
> index 44a9668..a4ea102 100644
> --- a/drivers/mmc/host/tmio_mmc.c
> +++ b/drivers/mmc/host/tmio_mmc.c
> @@ -88,8 +88,8 @@ static int __devinit tmio_mmc_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto cell_disable;
>  
> -	ret = request_irq(irq, tmio_mmc_irq, IRQF_DISABLED |
> -			  IRQF_TRIGGER_FALLING, dev_name(&pdev->dev), host);
> +	ret = request_irq(irq, tmio_mmc_irq, IRQF_TRIGGER_FALLING,
> +				dev_name(&pdev->dev), host);
>  	if (ret)
>  		goto host_remove;
>  
> -- 
> 1.7.4.1
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/