linux-kernel - Re: [PATCH] efi: Avoid sysfs spew on reboot and panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110921124018.GA22155@srcf.ucam.org>
Date:	Wed, 21 Sep 2011 13:40:18 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	Chen Gong <gong.chen@...ux.intel.com>
Cc:	tony.luck@...el.com, linux-kernel@...r.kernel.org,
	mikew@...gle.com, saguchi@...hat.com
Subject: Re: [PATCH] efi: Avoid sysfs spew on reboot and panic

On Wed, Sep 21, 2011 at 11:31:40AM +0800, Chen Gong wrote:
> >  	mutex_lock(&psinfo->buf_mutex);
> >  	memcpy(psinfo->buf, buf, size);
> >-	id = psinfo->write(type, 0, size, psinfo);
> >+	id = psinfo->write(type, 0, KMSG_DUMP_UNKNOWN, size, psinfo);
> 
> I can't say it is wrong because no real caller for this function, but I can't
> say it is right, yet. KMSG_DUMP_UNKNOWN here looks too arbirary. Do you have
> any reason to use this type here ?

If a function calls pstore_write() directly then we have no type to 
associate with it. It seems worth making this explicit.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/