linux-kernel - Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110921124936.GA25620@sirena.org.uk>
Date:	Wed, 21 Sep 2011 13:49:36 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Daniel Drake <dsd@...top.org>
Cc:	grant.likely@...retlab.ca, sameo@...ux.intel.com,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	dilinger@...ued.net
Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree
 node

On Wed, Sep 21, 2011 at 01:01:48PM +0100, Daniel Drake wrote:

> @@ -37,6 +38,9 @@ struct mfd_cell {
>  	void			*platform_data;
>  	size_t			pdata_size;
>  
> +	/* association with device tree node (optional) */
> +	struct device_node	*of_node;
> +

This doesn't seem great as it means that the mfd_cells can't be static
data, they have to be allocated per device.  Why can't the MFD cells get
at the OF node by using the parent device in the same way as they
(mostly) get platform data at the minute?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/