linux-kernel - Re: [PATCH V4] mtd: Add DiskOnChip G3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mxdwiicc.fsf@free.fr>
Date:	Thu, 22 Sep 2011 19:42:59 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	dedekind1@...il.com
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4] mtd: Add DiskOnChip G3 support

Artem Bityutskiy <dedekind1@...il.com> writes:

> Could you please re-base your driver on top of my l2 tree and fix
> warnings 0 I get the following:
Of course.

> BTW, the next step I'd do is to try to compile it with sparse, so you
> could test this driver with sparse: Documentation/sparse.txt
OK.

>> +#define doc_flashSequence(seq)						\
>> +do {									\
>> +	doc_dbg("doc_flashSequence: %02x " #seq "\n", DoC_Seq_##seq);	\
>> +	doc_writeb(DoC_Seq_##seq, DoC_FlashSequence);			\
>> +} while (0)
>> +
...zip...
>
> Could you please turn these macros into 'static inline' function - this
> is one of the modern patterns of kernel programming - we try to use
> functions for better type checking.
No sorry, that I cannot. If you look closely, the ##seq is not something you can
convert with an inline function, neither the #seq.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/