linux-kernel - Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Sep 2011 12:14:53 -0600 (MDT)
From:	Paul Walmsley <paul@...an.com>
To:	Keshava Munegowda <keshava_mgowda@...com>, parthab@...ia.ti.com
cc:	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, b-cousson@...com, balbi@...com,
	gadiyar@...com, sameo@...ux.intel.com, tony@...mide.com,
	khilman@...com, johnstul@...ibm.com, vishwanath.bs@...com
Subject: Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures
 for omap4

Hi

On Thu, 22 Sep 2011, Keshava Munegowda wrote:

> Following 4 hwmod structures are added
> 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock,
> 2. usb_ehci_hs hwmod with irq and base address,
> 3. usb_ohci_hs hwmod with irq and base address,
>    - The ehci and ohci hwmods does not require functional clock
>      because usb_host_hs has functional clock which is sufficient
>      to access ehci and ohci address space.
>    - The usb_ehci_hs and usb_ohci_hs should be two separate hwmods
>      which should not be combined. This is needed because ehci and
>      ohci will have separate dedicated ports & in omap4 there is a
>      clock per port.We should be able to configure the IO-Wakeup
>      capability of pins specific to EHCI & OHCI separately and depending
>      on the I/O wakeup event  the  only port clocks corresponding
>      to the wakeup source will be enabled internally by the usb host driver.
> 
> 4. usb_tll_hs hwmod of usbhs with the TLL base address and irq.

Many of the same issues with the OMAP3 data (missing main_clks, missing 
ADDR_TYPE_RT, etc.) exist with this patch also.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/