linux-kernel - Re: [PATCH 04/10] drbd: Replace and remove old primitives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGZ=bqJ_b54h9xid_PNwz-Ag6aNuvyUHx2QCm5UXpdc-JvHhKQ@mail.gmail.com>
Date:	Fri, 23 Sep 2011 13:33:45 -0400
From:	Kyle Moffett <kyle@...fetthome.net>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 04/10] drbd: Replace and remove old primitives

Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@...bit.com> wrote:
> From: Andreas Gruenbacher <agruen@...bit.com>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com>
> ---
>  drivers/block/drbd/drbd_int.h      |   45 +----
>  drivers/block/drbd/drbd_main.c     |  502 ++++++++++++++++--------------------
>  drivers/block/drbd/drbd_receiver.c |   86 ++++---
>  drivers/block/drbd/drbd_worker.c   |   24 +-
>  4 files changed, 294 insertions(+), 363 deletions(-)

I'm afraid this commit is waaaaay too large and complicated
to have a one-line commit message.

You should either split this up into more pieces or you should
write a detailed log indicated what this is supposed to be doing
and why it is OK.  (Or both).

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/