linux-kernel - Re: [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7186.1316799377@turing-police.cc.vt.edu>
Date:	Fri, 23 Sep 2011 13:36:17 -0400
From:	Valdis.Kletnieks@...edu
To:	frank.rowand@...sony.com
Cc:	tglx@...utronix.de, linux-rt-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL

On Thu, 22 Sep 2011 14:05:56 PDT, Frank Rowand said:
> Change from V1 to V2:  add drivers/tty/serial/8250.c

>  drivers/tty/serial/cpm_uart/cpm_uart_core.c |    2 	1 +	1 -	0 !
>  drivers/tty/serial/mfd.c                    |    2 	1 +	1 -	0 !
>  drivers/tty/serial/nwpserial.c              |    2 	1 +	1 -	0 !
>  drivers/tty/serial/omap-serial.c            |    2 	1 +	1 -	0 !
>  drivers/tty/serial/sunhv.c                  |    4 	2 +	2 -	0 !
>  drivers/tty/serial/sunsab.c                 |    2 	1 +	1 -	0 !
>  drivers/tty/serial/sunsu.c                  |    2 	1 +	1 -	0 !
>  drivers/tty/serial/sunzilog.c               |    2 	1 +	1 -	0 !
>  drivers/tty/serial/uartlite.c               |    2 	1 +	1 -	0 !
>  drivers/tty/serial/xilinx_uartps.c          |    2 	1 +	1 -	0 !

>  	if (up->port.sysrq)
>  		locked = 0;
> -	else if (oops_in_progress) {
> +	else if (oops_in_progress || sysrq_in_progress) {
>  		locked = spin_trylock(&up->port.lock);
>  	} else
>  		spin_lock(&up->port.lock);

Is it time to create a helper function for this chunk of code that appears
in almost identical form in a dozen drivers?

Content of type "application/pgp-signature" skipped