linux-kernel - Re: [PATCH 08/10] drbd: Introduce protocol version 100 headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Sep 2011 13:42:52 -0400
From:	Kyle Moffett <kyle@...fetthome.net>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 08/10] drbd: Introduce protocol version 100 headers

Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@...bit.com> wrote:
> From: Andreas Gruenbacher <agruen@...bit.com>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com>
> ---
>  drivers/block/drbd/drbd_int.h      |    8 ++++++++
>  drivers/block/drbd/drbd_main.c     |   31 +++++++++++++++++++++++++------
>  drivers/block/drbd/drbd_receiver.c |   14 ++++++++++++--
>  include/linux/drbd.h               |    1 +
>  4 files changed, 46 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
> index 9868518..7d679c5 100644
> --- a/drivers/block/drbd/drbd_int.h
> +++ b/drivers/block/drbd/drbd_int.h
> @@ -307,6 +307,14 @@ struct p_header95 {
>        u32       vol_n_len;    /* big endian: high byte = volume; remaining 24 bit = length */
>  } __packed;
>
> +struct p_header100 {
> +       u32       magic;
> +       u16       volume;
> +       u16       command;
> +       u32       length;
> +       u32       pad;
> +} __packed;
> +

This commit also needs additional log message text,
specifically something that indicates what is new and
different between the protocol 95 and protocol 100
headers.  (IE: Why was the change made?)

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/