linux-kernel - Re: [PATCH 04/10] drbd: Replace and remove old primitives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201109271134.02299.philipp.reisner@linbit.com>
Date:	Tue, 27 Sep 2011 11:34:01 +0200
From:	Philipp Reisner <philipp.reisner@...bit.com>
To:	Kyle Moffett <kyle@...fetthome.net>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 04/10] drbd: Replace and remove old primitives

Am Freitag, 23. September 2011, 19:33:45 schrieb Kyle Moffett:
> Hi!
> 
> On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
> 
> <philipp.reisner@...bit.com> wrote:
> > From: Andreas Gruenbacher <agruen@...bit.com>
> > 
> > Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
> > Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com>
> > ---
> >  drivers/block/drbd/drbd_int.h      |   45 +----
> >  drivers/block/drbd/drbd_main.c     |  502
> > ++++++++++++++++-------------------- drivers/block/drbd/drbd_receiver.c
> > |   86 ++++---
> >  drivers/block/drbd/drbd_worker.c   |   24 +-
> >  4 files changed, 294 insertions(+), 363 deletions(-)
> 
> I'm afraid this commit is waaaaay too large and complicated
> to have a one-line commit message.
> 
> You should either split this up into more pieces or you should
> write a detailed log indicated what this is supposed to be doing
> and why it is OK.  (Or both).
> 

I updated the patch to the following commit message:

Author: Andreas Gruenbacher <agruen@...bit.com>
Date:   Mon Mar 28 14:23:08 2011 +0200

    drbd: Replace and remove old primitives
    
    Centralize sock->mutex locking and unlocking in [drbd|conn]_prepare_command()
    and [drbd|conn]_send_comman().
    
    Therefore all *_send_* functions are touched to use these primitives instead
    of drbd_get_data_sock()/drbd_put_data_sock() and former helper functions.
    
    That change makes the *_send_* functions more standardized.
    
    Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
    Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com>


The complete, updated set is available at:
git://git.drbd.org/linux-2.6-drbd.git for-jens

Best,
 Phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/