[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110924052609.GI29998@game.jcrosoft.org>
Date: Sat, 24 Sep 2011 07:26:09 +0200
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To: Guennadi Liakhovetski <g.liakhovetski@....de>
Cc: Josh Wu <josh.wu@...el.com>, nicolas.ferre@...el.com,
linux-kernel@...r.kernel.org, s.nawrocki@...sung.com,
linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v3 2/2] at91: add Atmel ISI and ov2640 support on
sam9m10/sam9g45 board.
On 09:35 Thu 22 Sep , Guennadi Liakhovetski wrote:
> On Thu, 22 Sep 2011, Josh Wu wrote:
>
> > This patch
> > 1. add ISI_MCK parent setting code when add ISI device.
> > 2. add ov2640 support on board file.
> > 3. define isi_mck clock in sam9g45 chip file.
> >
> > Signed-off-by: Josh Wu <josh.wu@...el.com>
> > ---
> > arch/arm/mach-at91/at91sam9g45.c | 3 +
> > arch/arm/mach-at91/at91sam9g45_devices.c | 105 +++++++++++++++++++++++++++++-
> > arch/arm/mach-at91/board-sam9m10g45ek.c | 85 ++++++++++++++++++++++++-
> > arch/arm/mach-at91/include/mach/board.h | 3 +-
>
> Personally, I think, it would be better to separate this into two patches
> at least: one for at91 core and one for the specific board, but that's up
> to arch maintainers to decide.
>
> You also want to patch arch/arm/mach-at91/at91sam9263_devices.c, don't
> you?
agreed
Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists