linux-kernel - Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA_GA1czUfsP-mr74zMsLbjifx2Gsa-Fnv+V4yjfa0PUpyg-ow@mail.gmail.com>
Date:	Tue, 27 Sep 2011 17:40:02 +0800
From:	Bob Liu <lliubbo@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, joe@...ches.com,
	tglx@...utronix.de
Subject: Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half

On Tue, Sep 27, 2011 at 5:13 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, 2011-09-27 at 15:56 +0800, Bob Liu wrote:
>> local_bh_en/disable() has already deal with en/disable preempt, so rm the
>> dumplicated one from spinlock_api_up/smp.h head file.
>
> I bet you haven't tried booting this..  you just broke stuff like:
>

I only tried it on blackfin arch and can boot successfully
although it's a simple single-cpu ystem.

>  spin_lock_bh(&foo);
>  /* do crap */
>  spin_unlock(&foo);
>  /* do some other crap */
>  local_bh_enable();
>
>
> And yes that does happen.

Could you please give an example?  I did a simple search but no result.
I thought the user should use spin_lock_bh()/spin_unlock_bh() in pairs.

-- 
Regards,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/