linux-kernel - Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom half

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317114837.15383.1.camel@twins>
Date:	Tue, 27 Sep 2011 11:13:56 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Bob Liu <lliubbo@...il.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, joe@...ches.com,
	tglx@...utronix.de
Subject: Re: [PATCH] spinlock: rm duplicated preempt en/disable for bottom
 half

On Tue, 2011-09-27 at 15:56 +0800, Bob Liu wrote:
> local_bh_en/disable() has already deal with en/disable preempt, so rm the
> dumplicated one from spinlock_api_up/smp.h head file.

I bet you haven't tried booting this..  you just broke stuff like:

  spin_lock_bh(&foo);
  /* do crap */
  spin_unlock(&foo);
  /* do some other crap */
  local_bh_enable();


And yes that does happen.

  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/