linux-kernel - Re: [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110927115804.40ab56dc@bob.linux.org.uk>
Date:	Tue, 27 Sep 2011 11:58:04 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com>
Cc:	linux-serial@...r.kernel.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data_output
 (adaption = 2 case)

On Fri, 23 Sep 2011 19:22:55 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com> wrote:

> in adaption=2 case we should put 1 or 2 byte with modem status bits
> at the beginning of a buffer pointed by "dp". n_gsm use 1 byte case,
> so it allocate a buffer of len + 1 size. As result we should:
>   * put 1 byte of modem status bits
>   * increase data pointer
>   * put "len" bytes of data
> but actually we have:
>   * increase first byte with the value of modem status bits
>   * decrease "len"
>   * put orig_len - 1 bytes of data starting from the buffer beggining
> This is evidently wrong.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com>

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/