linux-kernel - Re: [PATCH 2/2] tty/n_gsm: avoid fifo overflow in gsm_dlci_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110927115957.5e6cb79c@bob.linux.org.uk>
Date:	Tue, 27 Sep 2011 11:59:57 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com>
Cc:	linux-serial@...r.kernel.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tty/n_gsm: avoid fifo overflow in
 gsm_dlci_data_output

On Fri, 23 Sep 2011 19:22:56 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com> wrote:

> n_gsm use a simple approach: every writing to fifo correspond exactly
> one reading from fifo. There are no problem in this approach until we
> read less bytes then we write. As result fifo may owerflow. This
> leads to packet loss and very slow responce.

We do need to do something here but your change means a single DLCI
will hog the channel, so I think the while loop needs to be one layer
up.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/