linux-kernel - Re: [PATCH] block: Free queue resources at blk_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E832A55.30709@kernel.dk>
Date:	Wed, 28 Sep 2011 08:08:21 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Hannes Reinecke <hare@...e.de>,
	James Bottomley <James.Bottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: Free queue resources at blk_release_queue()

On 2011-09-27 22:10, James Bottomley wrote:
> On Tue, 2011-09-27 at 18:59 -0700, Linus Torvalds wrote:
>> On Tue, Sep 27, 2011 at 6:15 PM, Jens Axboe <axboe@...nel.dk> wrote:
>>>>
>>>> But if you forward the actual patch to me (the one I see on lkml seems
>>>> to be broken and doesn't compile cleanly because it's assiging a
>>>> structure to a pointer), I'll try it out anyway.
>>>
>>> Thanks, that would be great. It's inlined below.
>>
>> Well, I did several USB eject events, and nothing bad happened.
>>
>> But as mentioned, I don't think that means much. Have you tried this
>> with slub debugging and poisoning? It might be worth some extra
>> testing that way.
> 
> I've been testing a simpler version:
> 
> http://marc.info/?l=linux-kernel&m=131300594629839
> 
> For a long time now with great success.  The only difference is the
> locking cleanup, but SCSI doesn't need that since it doesn't supply its
> own lock, so I've been voting for this as the final fix for a while now.

The locking cleanup looks good, though, for devices that do use the
embedded lock. But functionally they should be the same for SCSI, so if
you had great success with it, then that's a good data point.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/