linux-kernel - Re: [PATCH v3 20/24] C6X: library code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201109281609.41468.arnd@arndb.de>
Date:	Wed, 28 Sep 2011 16:09:41 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Mark Salter <msalter@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v3 20/24] C6X: library code

On Tuesday 27 September 2011, Mark Salter wrote:
> +++ b/arch/c6x/include/asm/checksum.h
> @@ -0,0 +1,115 @@
> +/*
> + *  Port on Texas Instruments TMS320C6x architecture
> + *
> + *  Copyright (C) 2004, 2009, 2010 Texas Instruments Incorporated
> + *  Author: Aurelien Jacquiot (aurelien.jacquiot@...una.com)
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + */
> +#ifndef _ASM_C6X_CHECKSUM_H
> +#define _ASM_C6X_CHECKSUM_H
> +
> +#include <asm/byteorder.h>

I think you should fall back on the generic checksum.h file and only
provide the declarations that are different. This file is largely
identical to the generic version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/