linux-kernel - Re: [PATCH v3 21/24] C6X: general SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201109281619.07213.arnd@arndb.de>
Date:	Wed, 28 Sep 2011 16:19:07 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Mark Salter <msalter@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v3 21/24] C6X: general SoC support

On Tuesday 27 September 2011, Mark Salter wrote:
> +int soc_mac_addr(unsigned int index, u8 *addr)
> +{
> +       int i, have_cmdline_mac = 0, have_fuse_mac = 0;
> +
> +       for (i = 0; i < 6; i++) {
> +               if (cmdline_mac[i])
> +                       have_cmdline_mac = 1;
> +               if (c6x_fuse_mac[i])
> +                       have_fuse_mac = 1;
> +       }
> +
> +       /* cmdline overrides hardware fuse MAC */
> +       if (have_cmdline_mac)
> +               memcpy(addr, cmdline_mac, 6);
> +       else if (have_fuse_mac)
> +               memcpy(addr, c6x_fuse_mac, 6);
> +       else
> +               return 0;

IMHO it's more important to let the user override the MAC address through
the device tree than the command line, although if you allow both, the
command line should take precedence. If you think you need to keep the
command line option, please add a way to read it from the device tree
as a fallback before falling back to the fused mac address.

Also, a final fallback on random_mac_address() would be reasonable here.

Finally, how about passing a struct device pointer from the driver, rather
than the index? That would seem more logical and make it easier to get
to the device tree properties.

> +       /* adjust for specific EMAC device */
> +       addr[5] += index * c6x_num_cores;
> +       return 1;
> +}
> +EXPORT_SYMBOL(soc_mac_addr);

EXPORT_SYMBOL_GPL()

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/