linux-kernel - Re: [PATCH] regulator: Support driver probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110929163515.GA6800@ponder.secretlab.ca>
Date:	Thu, 29 Sep 2011 11:35:15 -0500
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...com>, Grant Likely <grant@...retlab.ca>,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com,
	"G, Manjunath Kondaiah" <manjugk@...com>
Subject: Re: [PATCH] regulator: Support driver probe deferral

On Thu, Sep 29, 2011 at 12:11:01PM +0100, Mark Brown wrote:
> If we fail to locate a requested regulator return -EAGAIN. If drivers
> pass this error code through to their caller (which they really should)
> then this will ensure that the probe is retried later when further devices
> become available.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Acked-by: Grant Likely <grant.likely@...retlab.ca>

Manjunath, can you add this to a series with the deferred probe patch?
You'll need to change the return code as discussed in the other
thread.

g.

> ---
> 
> This depends on Grant's change to implement deferred probing, the error
> code for which is going to change in the next revision.  Liam, if you're
> also OK with this change I propose that we both ack it and let it get
> carried along with the deferred probing change.
> 
>  drivers/regulator/core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index d5656b7..b39ec9f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1154,7 +1154,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>  {
>  	struct regulator_dev *rdev;
>  	struct regulator_map *map;
> -	struct regulator *regulator = ERR_PTR(-ENODEV);
> +	struct regulator *regulator = ERR_PTR(-EAGAIN);
>  	const char *devname = NULL;
>  	int ret;
>  
> @@ -2727,7 +2727,7 @@ struct regulator_dev *regulator_register(struct regulator_desc *regulator_desc,
>  		if (!found) {
>  			dev_err(dev, "Failed to find supply %s\n",
>  				init_data->supply_regulator);
> -			ret = -ENODEV;
> +			ret = -EAGAIN;
>  			goto scrub;
>  		}
>  
> -- 
> 1.7.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/