linux-kernel - Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317327729.12332.121.camel@ted>
Date:	Thu, 29 Sep 2011 21:22:01 +0100
From:	Richard Purdie <richard.purdie@...uxfoundation.org>
To:	Andrew Morton <akpm00@...il.com>
Cc:	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] backlight: Rename corgibl_limit_intensity to
 genericbl_limit_intensity

On Thu, 2011-09-29 at 13:00 -0700, Andrew Morton wrote:
> On Sun, 25 Sep 2011 10:12:33 +0800
> Axel Lin <axel.lin@...il.com> wrote:
> 
> > The rename of corgibl_limit_intensity is missed in commit d00ba726
> > "backlight: Rename the corgi backlight driver to generic".
> > Let's fix it now.
> > 
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > Cc: Richard Purdie <rpurdie@...ys.net>
> > ---
> >  drivers/video/backlight/generic_bl.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> > index 8c6befd..adb1914 100644
> > --- a/drivers/video/backlight/generic_bl.c
> > +++ b/drivers/video/backlight/generic_bl.c
> > @@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> >   * Called when the battery is low to limit the backlight intensity.
> >   * If limit==0 clear any limit, otherwise limit the intensity
> >   */
> > -void corgibl_limit_intensity(int limit)
> > +void genericbl_limit_intensity(int limit)
> >  {
> >  	struct backlight_device *bd = generic_backlight_device;
> >  
> > @@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)
> >  	backlight_update_status(generic_backlight_device);
> >  	mutex_unlock(&bd->ops_lock);
> >  }
> > -EXPORT_SYMBOL(corgibl_limit_intensity);
> > +EXPORT_SYMBOL(genericbl_limit_intensity);
> >  
> 
> Why does corgibl_limit_intensity/genericbl_limit_intensity exist? 
> Nothing in the tree references it?

It sounds like someone has removed the sharpsl battery driver which did
use this. If this hook isn't used, low battery with high screen
backlight values will reset the device as the wiring isn't up to the
current draw.

Richard


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/