linux-kernel - Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1317379490.12332.145.camel@ted>
Date:	Fri, 30 Sep 2011 11:44:42 +0100
From:	Richard Purdie <richard.purdie@...uxfoundation.org>
To:	axel.lin@...il.com
Cc:	Andrew Morton <akpm00@...il.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] backlight: Rename corgibl_limit_intensity to
 genericbl_limit_intensity

On Fri, 2011-09-30 at 07:45 +0800, Axel Lin wrote:
> >> Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
> >> Nothing in the tree references it?
> >
> > It sounds like someone has removed the sharpsl battery driver which did
> > use this. If this hook isn't used, low battery with high screen
> > backlight values will reset the device as the wiring isn't up to the
> > current draw.
> >
> It is removed by commit 13a542475d1c62a12c77abfa83a790245598fc61
> Author: Christoph Egger <siccegge@...fau.de>
> Date:   Sun Jul 4 23:24:52 2010 +0800
> 
>     [ARM] pxa: removing dead BACKLIGHT_CORGI
> 
>     BACKLIGHT_CORGI was later renamed to BACKLIGHT_GENERIC and has not been
>     used since then. As it's now safe to completely transition to LCD_CORGI
>     driver, which incorprates both the LCD and backlight device.
> 
>     Signed-off-by: Christoph Egger <siccegge@...fau.de>
>     Signed-off-by: Eric Miao <eric.y.miao@...il.com>
> 
> So, should we remove corgibl_limit_intensity/genericbl_limit_intensity
> since now it is not being used?

Does that code workaround the hardware issue I mention? I suspect not.
It seems nobody cares about that at this point though...

Cheers,

Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/