linux-kernel - Re: [PATCH v13 2/4] PM: Introduce devfreq: generic DVFS framework with device-specific OPPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <201109301841.41666.rjw@sisk.pl>
Date:	Fri, 30 Sep 2011 18:41:41 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	xiaojiang <jgq516@...il.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-pm@...ts.linux-foundation.org, Pavel Machek <pavel@....cz>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	Kevin Hilman <khilman@...com>, Nishanth Menon <nm@...com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Colin Cross <ccross@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mike Turquette <mturquette@...com>, myungjoo.ham@...il.com
Subject: Re: [PATCH v13 2/4] PM: Introduce devfreq: generic DVFS framework with device-specific OPPs

On Friday, September 30, 2011, xiaojiang wrote:
> On 2011?09?29? 20:18, MyungJoo Ham wrote:
> > +/**
> > + * find_device_devfreq() - find devfreq struct using device pointer
> > + * @dev:	device pointer used to lookup device devfreq.
> > + *
> > + * Search the list of device devfreqs and return the matched device's
> > + * devfreq info. devfreq_list_lock should be held by the caller.
> > + */
> > +static struct devfreq *find_device_devfreq(struct device *dev)
> > +{
> > +	struct devfreq *tmp_devfreq;
> > +
> > +	if (unlikely(IS_ERR_OR_NULL(dev))) {
> > +		pr_err("DEVFREQ: %s: Invalid parameters\n", __func__);
> > +		return ERR_PTR(-EINVAL);
> > +	}
> > +	WARN(!mutex_is_locked(&devfreq_list_lock),
> > +	     "devfreq_list_lock must be*loced*.");
> A typo, it should be locked.

Thanks, I'll fix it up.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/