linux-kernel - Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Sep 2011 18:46:41 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Jean Pihet <jean.pihet@...oldbits.com>
Cc:	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Linux-sh list" <linux-sh@...r.kernel.org>,
	Magnus Damm <magnus.damm@...il.com>,
	Kevin Hilman <khilman@...com>, Ming Lei <tom.leiming@...il.com>
Subject: Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2)

On Friday, September 30, 2011, Jean Pihet wrote:
> Hi Rafael,
> 
> On Thu, Sep 29, 2011 at 10:33 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> > Hi,
> >
> > On Thursday, September 29, 2011, Jean Pihet wrote:
> >> Hi Rafael,
> >>
> >> I have a few minor remarks, inlined below.
> >
> > In the meantime it turned out that the patch caused a build failure
> > for CONFIG_PM_SLEEP unset (your original patches won't really work
> > in this case too), so I posted a patch to fix it.  However, since
> > you had remarks anyway, I've simply folded the fix into the next
> > version of the $subject patch, which is appended.
> OK to me.
> 
> I have 2 remarks though:
> - some drivers are using the power_state field in the suspend/resume
> operation, IIUC without conflict. Can you confirm?

Yes, I can.  There are no conflicts.

> - the power_state field is scheduled for removal, cf.
> Documentation/feature-removal-schedule.txt. That does not look
> correct.

It still is schediled for removal, but we can't remove it right now
anyway because of the users mentioned above.  I'll replace this field
with a one-bit flag when we're ready to drop it (some time in future).

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/