linux-kernel - Re: [PATCH] intel_sst: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 30 Sep 2011 13:39:50 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	Lu Guanqun <guanqun.lu@...el.com>, <gregkh@...e.de>,
	<sfr@...b.auug.org.au>, <linux-next@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <alan@...ux.intel.com>,
	<fengguang.wu@...el.com>, <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] intel_sst: fix compile error

On 11-09-29 10:34 PM, Vinod Koul wrote:
> On Fri, 2011-09-30 at 10:35 +0800, Lu Guanqun wrote:
>> include module.h to fix the following compile errors:
>>
>> drivers/staging/intel_sst/intelmid.c:52: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:52: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:52: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>> drivers/staging/intel_sst/intelmid.c:52: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:53: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:53: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:53: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>> drivers/staging/intel_sst/intelmid.c:53: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:54: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:54: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:54: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>> drivers/staging/intel_sst/intelmid.c:54: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:55: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:55: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:55: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>> drivers/staging/intel_sst/intelmid.c:55: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:56: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:56: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:56: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
>> drivers/staging/intel_sst/intelmid.c:56: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:57: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:57: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:57: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
>> drivers/staging/intel_sst/intelmid.c:57: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:58: error: expected declaration specifiers or '...' before string constant
>> drivers/staging/intel_sst/intelmid.c:58: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:58: warning: type defaults to 'int' in declaration of 'MODULE_SUPPORTED_DEVICE'
>> drivers/staging/intel_sst/intelmid.c:58: warning: function declaration isn't a prototype
>> drivers/staging/intel_sst/intelmid.c:64: error: expected ')' before 'int'
>> drivers/staging/intel_sst/intelmid.c:65: error: expected ')' before string constant
>> drivers/staging/intel_sst/intelmid.c:66: error: expected ')' before numeric constant
>> drivers/staging/intel_sst/intelmid.c:67: error: expected ')' before string constant
>> drivers/staging/intel_sst/intelmid.c:461: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:461: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
>> drivers/staging/intel_sst/intelmid.c:461: warning: parameter names (without types) in function declaration
>> drivers/staging/intel_sst/intelmid.c:475: warning: data definition has no type or storage class
>> drivers/staging/intel_sst/intelmid.c:475: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
>> drivers/staging/intel_sst/intelmid.c:475: warning: parameter names (without types) in function declaration
>> drivers/staging/intel_sst/intelmid.c: In function 'snd_intelmad_probe':
>> drivers/staging/intel_sst/intelmid.c:859: error: 'THIS_MODULE' undeclared (first use in this function)
>> drivers/staging/intel_sst/intelmid.c:859: error: (Each undeclared identifier is reported only once
>> drivers/staging/intel_sst/intelmid.c:859: error: for each function it appears in.)
>> drivers/staging/intel_sst/intelmid.c: At top level:
>> drivers/staging/intel_sst/intelmid.c:989: error: 'THIS_MODULE' undeclared here (not in a function)

A minor nit, but we probably don't need all 70 lines of the
compile failure in the long log.  It doesn't really add any
value or information.  Just a comment that the file really
needs module.h since it is a module source file would suffice.

Thanks,
Paul.

>>
>> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
>> Signed-off-by: Lu Guanqun <guanqun.lu@...el.com>
>> ---
>>  drivers/staging/intel_sst/intelmid.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/intel_sst/intelmid.c b/drivers/staging/intel_sst/intelmid.c
>> index 25656ad..492b660 100644
>> --- a/drivers/staging/intel_sst/intelmid.c
>> +++ b/drivers/staging/intel_sst/intelmid.c
>> @@ -27,6 +27,7 @@
>>  
>>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>>  
>> +#include <linux/module.h>
>>  #include <linux/slab.h>
>>  #include <linux/io.h>
>>  #include <linux/platform_device.h>
> Thanks I was midway of creating this fix :)
> 
> Acked-by: Vinod Koul <vinod.koul@...el.com>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/