linux-kernel - Re: [PATCH 3/9] Staging: comedi: fix printk issue in cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111001150942.GD3901@longonot.mountain>
Date:	Sat, 1 Oct 2011 18:09:42 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Ravishankar Karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/9] Staging: comedi: fix printk issue in cb_pcidas.c

On Fri, Sep 30, 2011 at 06:48:21PM +0530, Ravishankar Karkala Mallikarjunayya wrote:
>  	if (comedi_pci_enable(pcidev, "cb_pcidas")) {
> -		printk(" Failed to enable PCI device and request regions\n");
> +		dev_err(&pcidev->dev, " Failed to enable PCI "
                                       ^
This space isn't needed any more now that it's at the start of a
line.

> +			"device and request regions\n");
>  		return -EIO;

I'm not going to review the remaining 6 patches.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/