linux-kernel - Re: [PATCH 1/9] Staging: comedi: fix printk issue in cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E8A44ED.4090406@gmail.com>
Date:	Tue, 04 Oct 2011 10:27:41 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Ravishankar Karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
CC:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] Staging: comedi: fix printk  issue in cb_pcidio.c

On 30/09/11 23:18, Ravishankar Karkala Mallikarjunayya wrote:

> This is a patch to the cb_pcidio.c file that fixes up a printk warning found by the checkpatch.pl tool
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>
> ---
>  drivers/staging/comedi/drivers/cb_pcidio.c |   27 +++++++++++++++------------
>  1 files changed, 15 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidio.c b/drivers/staging/comedi/drivers/cb_pcidio.c
> index 79477a5..85cc78d 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidio.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidio.c
> @@ -184,7 +184,8 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	int index;
>  	int i;
>  
> -	printk("comedi%d: cb_pcidio: \n", dev->minor);
> +	dev_info(&pcidev->dev, "comedi%d: cb_pcidio:\n",
> +		dev->minor);
>  
>  /*
>   * Allocate the private structure area.  alloc_private() is a
> @@ -223,8 +224,9 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  		}
>  	}
>  
> -	printk("No supported ComputerBoards/MeasurementComputing card found on "
> -	       "requested position\n");
> +	dev_err(&pcidev->dev, "No supported"
> +		" ComputerBoards/MeasurementComputing"
> +		" card found on requested position\n");


printk strings should be on a single line (80 column rule doesn't apply)
so that they can be easily grepped for. There are many instances which
need to be fixed in this series.

~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/