linux-kernel - Re: [RFC][PATCH] ASoC: Avoid writing to WM8971_RESET in wm8971

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111004150403.GI6934@opensource.wolfsonmicro.com>
Date:	Tue, 4 Oct 2011 16:04:04 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Kenneth Kiraly <kiraly@...126.com>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org
Subject: Re: [RFC][PATCH] ASoC: Avoid writing to WM8971_RESET in wm8971_resume

On Tue, Oct 04, 2011 at 07:44:22AM +0800, Axel Lin wrote:

> While reading the code, I don't understand why we need to do (in wm8971_resume):
> 
> for (i = 0; i < ARRAY_SIZE(wm8971_reg); i++) {
>         if (i + 1 == WM8971_RESET)
>                 continue;
> 
> My understanding is that we want to avoid writing to WM8971_RESET on resume.

Yeah, this looks like a leftover from some older code which omitted
register zero from the cache for some small memory savings.  Now things
are using the standard cache code rather than custom cache code this
is buggy.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/