linux-kernel - Re: [PATCH v6] fat: Batched discard support for fat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1110051636220.4423@dhcp-27-109.brq.redhat.com>
Date:	Wed, 5 Oct 2011 16:38:04 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
cc:	Kyungmin Park <kmpark@...radead.org>,
	Lukas Czerner <lczerner@...hat.com>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v6] fat: Batched discard support for fat

On Thu, 1 Sep 2011, OGAWA Hirofumi wrote:

> Kyungmin Park <kmpark@...radead.org> writes:
> 
> > Hi Ogawa,
> 
> Hi,
> 
> > Do you still object to merge batched discard support on fat?
> >
> > If the current batched discard concept doesn't changed, it can't merge it?
> 
> I'm not blaming "concept". I'm saying current implements (and due to
> current interface confusion) is confusing and makes userland hard to use it.
> 
> I really think I explained all my concerns and current implement
> confusion.
> 
> Last time I checked, those implementations had even the different error
> code at EOF. How can I say your implement will work without knowing
> right implement?
> 
> Again, it is reason, and I'm not blaming "concept" or your implement
> itself.
> 
> Thanks.

Please see test #260 in xfstests, which was recently added to check for
common mistakes in FITRIM argument handling.

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/