linux-kernel - RE: [PATCH 6/8] x86, topology.c: Enable CPU0 online/offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493994B35A117E4F832F97C4719C4C040136F7CECC@orsmsx505.amr.corp.intel.com>
Date:	Wed, 5 Oct 2011 16:05:21 -0700
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Ingo Molnar <mingo@...e.hu>, H Peter Anvin <hpa@...or.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	"Mallick, Asit K" <asit.k.mallick@...el.com>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	"Brown, Len" <len.brown@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 6/8] x86, topology.c: Enable CPU0 online/offline

> 
> > +	 * Suspend/resume depends on BSP. Certain PCI quirks (which PCI
> > +	 * quirks??) require not to enable hotplug control for all CPU's.
> 
> Again, you dammit better make shure which quirks break when cpu0 is
> offlined.
> 

Maybe I misunderstood the comment in arch/x86/kernel/topology.c

+        * Also certain PCI quirks require not to enable hotplug control
+        * for all CPU's.
+        */

and commit b0d0a4ba45760b10ecee9035ed45b442c1a6cc84

So there is NO PCI quirks dependency on CPU0 hotplug.

I'm going to send out a new cpu0 online/offline patch set after collecting all the comments so far.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/