linux-kernel - Re: [PATCH 06/10] ASoC: wm8940: Convert to snd_soc_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF+7xWnWaPB8JKepUoGmvpVw6W6pJPVNkXAdy9GTD2rf9QDUNQ@mail.gmail.com>
Date:	Thu, 6 Oct 2011 19:33:29 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Ian Lartey <ian@...nsource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org
Subject: Re: [PATCH 06/10] ASoC: wm8940: Convert to snd_soc_cache_sync

>> +static int wm8940_volatile_register(struct snd_soc_codec *codec,
>> +                                 unsigned int reg)
>> +{
>> +     switch (reg) {
>> +     case WM8940_SOFTRESET:
>> +             return 1;
>> +     default:
>> +             return 0;
>> +     }
>> +}
> I guess this makes sense from point of view of keeping things inline with
> more complex drivers.  Otherwise I'd expect to see something like:
> {
>        return !!(reg == WM894_SOFTRESET);
> }

Either is ok to me.
But current syntax makes it easier to add more registers to be volatile
if necessary.

So I'll let Mark decide if I need to send a v2 for changing this.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/