linux-kernel - Re: [PATCH 06/10] ASoC: wm8940: Convert to snd_soc_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111006131811.GA16404@opensource.wolfsonmicro.com>
Date:	Thu, 6 Oct 2011 14:18:12 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Ian Lartey <ian@...nsource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org
Subject: Re: [PATCH 06/10] ASoC: wm8940: Convert to snd_soc_cache_sync

On Thu, Oct 06, 2011 at 12:28:41PM +0100, Jonathan Cameron wrote:
> On 10/06/11 07:17, Axel Lin wrote:

> > +static int wm8940_volatile_register(struct snd_soc_codec *codec,
> > +				    unsigned int reg)
> > +{
> > +	switch (reg) {
> > +	case WM8940_SOFTRESET:
> > +		return 1;
> > +	default:
> > +		return 0;
> > +	}
> > +}

> I guess this makes sense from point of view of keeping things inline with
> more complex drivers.  Otherwise I'd expect to see something like:
> {
> 	return !!(reg == WM894_SOFTRESET);
> }

On the other hand we actually want people to be able to read the code
(though the !! there which is the major complication isn't actually
doing anything...).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/