linux-kernel - Re: [PATCH] PM: HIBERNATION: add resume_wait param to support MMC-like devices as resume file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111006175818.GB9886@atrey.karlin.mff.cuni.cz>
Date:	Thu, 6 Oct 2011 19:58:18 +0200
From:	Pavel Machek <pavel@....cz>
To:	Barry Song <21cnbao@...il.com>
Cc:	Luca Tettamanti <kronos.it@...il.com>,
	Barry Song <Barry.Song@....com>, frank.hofmann@...tom.com,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	workgroup.linux@....com, rjw@...k.pl,
	linux-pm@...ts.linux-foundation.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] PM: HIBERNATION: add resume_wait param to support
	MMC-like devices as resume file

> 2011/9/29 Luca Tettamanti <kronos.it@...il.com>:
> > On Thu, Sep 29, 2011 at 11:29 AM, Barry Song <Barry.Song@....com> wrote:
> >> From: Barry Song <baohua.song@....com>
> >>
> >> Some devices like mmc are async detected very slow. For example,
> >> drivers/mmc/host/sdhci.c launchs a 200ms delayed work to detect
> >> mmc partitions then add disk.
> >>
> >> we do have wait_for_device_probe and scsi_complete_async_scans
> >> before calling swsusp_check, but it is not enough to wait mmc.
> >>
> >> This patch adds resumewait kernel param just like rootwait so
> >> that we have enough time to wait mmc ready. The differene is
> >> here we wait for resume partition but rootwait waits for rootfs
> >> partition.
> >
> > I assume that such a device would need "rootwait" to boot in the first
> > place; why don't you "overload" the param to also enable waiting in
> > the resume path?
> 
> not real. for an embedded product, the type of the rootfs, the place
> of the rootfs  and the way to mount rootfs are pretty flexible.
> even though both rootfs and resume file use mmc, they will be in
> different partitions at least. so i don't think rootwait can overload
> resumewait.

It would be good to at least model it the same way. rootdelay allows
you to specify time, which is important for USB devices...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/