linux-kernel - Re: [PATCH 4/4] staging: et131x: Update TODO list

Open Source and information security mailing list archives

Message-ID: <CAP2e6W9oQWLxe7pJxk=Awn1HTueeu41ZV7TFF+V9tHF07_Mxag@mail.gmail.com>
Date:	Tue, 11 Oct 2011 09:00:35 -0700
From:	Ramesh R <rshlinux@...il.com>
To:	Mark Einon <mark.einon@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: et131x: Update TODO list

Hi Mark,

I wish to contribute to this project - From the latest TODO list in
the README document

drivers/staging/et131x/README

If I were to start with the coding style cleanups, is there a coding
standard available for reference? Please advice.

Thanks
Ramesh

On Mon, Oct 10, 2011 at 8:22 AM, Mark Einon <mark.einon@...il.com> wrote:
> Added some more tasks to the TODO list, as highlighted by Francois
> Romieu <romieu@...zoreil.com>.
>
> Signed-off-by: Mark Einon <mark.einon@...il.com>
> ---
>  drivers/staging/et131x/README |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
> index d383e80..c67f83e 100644
> --- a/drivers/staging/et131x/README
> +++ b/drivers/staging/et131x/README
> @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.
>
>  Based on the driver found at https://sourceforge.net/projects/et131x/
>
> -Cleaned up immensely by Olaf Hartman and Christoph
> -Hellwig <hch@...radead.org>
> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@...radead.org>
>
>  Note, the powermanagement options were removed from the vendor provided
>  driver as they did not build properly at the time.
>
>  TODO:
> +       - Put the driver into a single file, with a .h for the registers layout.
> +       - rx_ring.fbr{0, 1} can probably share a common structure
> +       - Use of kmem_cache seems a bit unusual
> +       - Use dma_alloc_... in place of pci_alloc_...
> +       - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
> +       - PCI_VDEVICE ?
>
>  Please send patches to:
>        Greg Kroah-Hartman <gregkh@...e.de>
> --
> 1.7.6.4
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives