linux-kernel - Re: [PATCH v2 2/6] MFD: twl6040: Cache the vibra control registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Oct 2011 09:01:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Peter Ujfalusi <peter.ujfalusi@...com>,
	Samuel Ortiz <samuel.ortiz@...el.com>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Misael Lopez Cruz <misael.lopez@...com>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH v2 2/6] MFD: twl6040: Cache the vibra control registers

On Tue, Oct 11, 2011 at 03:48:24PM +0100, Mark Brown wrote:
> On Fri, Sep 23, 2011 at 09:49:40AM +0300, Peter Ujfalusi wrote:
> > The vibra control register will be used from the ASoC codec driver as well.
> > In order to avoid latency issues caused by I2C read access, cache the two
> > control register within the core driver, so we do not need to reach out
> > to the chip to read it back.
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> 
> It strikes me that it might be useful to just convert the driver to
> regmap and get cache for everything...
> 
> Anyway, could you please restructure this series to minimize the
> dependency on the input subsystem?  Then we can get the rest of it
> applied.
> 

I'm OK with all patches going through MFD - I do not believe it will
cause any merge issues.

For the record I still do not like returning EBUSY when device is not
available - I think if device can't serve any requests it should not
exists at all.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/