linux-kernel - [PATCH] Fix strim() semantics for strings that have only blanks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318408317.2891.3.camel@br98xy6r>
Date:	Wed, 12 Oct 2011 10:31:57 +0200
From:	Michael Holzheu <holzheu@...ux.vnet.ibm.com>
To:	andre.goddard@...il.com
Cc:	akpm@...ux-foundation.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux-kernel@...r.kernel.org
Subject: [PATCH] Fix strim() semantics for strings that have only blanks

Hello Andre,

With git commit 84c95c9acf088c99d8793d78036b67faa5d0b851 a patch from
you went upstream where you wanted to improve the performance of the
strim() function.

Unfortunately this changed the semantics of strim() and broke my code. Before
the patch it was possible to use strim() without using the return value for
removing trailing spaces from strings that had either only blanks or only
trailing blanks.

Now this does not work any longer for strings that *only* have blanks.

Before patch: "   " -> ""    (empty string)
After patch:  "   " -> "   " (no change)

I think we should remove your patch to restore the old behavior.

>From the description (lib/string.c):

 * Note that the first trailing whitespace is replaced with a %NUL-terminator

=> The first trailing whitespace of a string that only has whitespace
   characters is the first whitespace

Also strim() explicitly does not have "__must_check", in order to use it
without using the return value.

I attached a patch that restores the old strim() semantics.

Signed-off-by: Michael Holzheu <holzheu@...ux.vnet.ibm.com>
---
 lib/string.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/lib/string.c
+++ b/lib/string.c
@@ -360,7 +360,6 @@ char *strim(char *s)
 	size_t size;
 	char *end;

-	s = skip_spaces(s);
 	size = strlen(s);
 	if (!size)
 		return s;
@@ -370,7 +369,7 @@ char *strim(char *s)
 		end--;
 	*(end + 1) = '\0';

-	return s;
+	return skip_spaces(s);
 }
 EXPORT_SYMBOL(strim);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/