linux-kernel - Re: [PATCH] cy82c693: fix PCI device selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111012185821.2955b861@lxorguk.ukuu.org.uk>
Date:	Wed, 12 Oct 2011 18:58:21 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	David Miller <davem@...emloft.net>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cy82c693: fix PCI device selection

On Wed, 12 Oct 2011 16:52:10 +0200
Bartlomiej Zolnierkiewicz <bzolnier@...il.com> wrote:

> David Miller wrote:
> 
> > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> > Date: Tue, 11 Oct 2011 19:37:32 +0200
> > 
> > > While at it remove redundant pci_get_slot() call as cy82c693_init_one()
> > > already takes care of keeping the reference on the second port's PCI
> > > device.
> > 
> > Please do not submit unrelated changes with a bug fix, and as IDE is
> > in long-term maintainence I would not accept a risky refinement like
> > this anyways.
> 
> Removed code is just bogus, we cannot fail in ->set_pio_mode method.
> 
> Please take a look at the code:
>  
> -	/* select primary or secondary channel */
> -	if (hwif->index > 0) {  /* drive is on the secondary channel */
> -		dev = pci_get_slot(dev->bus, dev->devfn+1);
> -		if (!dev) {
> -			printk(KERN_ERR "%s: tune_drive: "
> -				"Cannot find secondary interface!\n",
> -				drive->name);
> -			return;
> -		}
> -	}
> 
> Please apply the patch, libata's pata_cypress doesn't support secondary
> port currently and cy82c693 driver is the only way to use this hardware.

I've not found anyone using an Alpha 164SX in years so it's not been
possible to do the updates and test them. And no ... do not offer to send
me an Alpha, donate it to a museum.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/