linux-kernel - [PATCH v2 3/4] ata_piix: CodingStyle fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Oct 2011 15:43:29 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2 3/4] ata_piix: CodingStyle fixes

From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: [PATCH] ata_piix: CodingStyle fixes

CodingStyle fixes for piix_port_info[].

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---
 drivers/ata/ata_piix.c |   68 ++++++++++++++-----------------------------------
 1 file changed, 20 insertions(+), 48 deletions(-)

Index: b/drivers/ata/ata_piix.c
===================================================================
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -473,131 +473,103 @@ static const struct piix_map_db *piix_ma
 };
 
 static struct ata_port_info piix_port_info[] = {
-	[piix_pata_mwdma] = 	/* PIIX3 MWDMA only */
-	{
+	[piix_pata_mwdma] = {	/* PIIX3 MWDMA only */
 		.flags		= PIIX_PATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
-		.mwdma_mask	= ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
+		.mwdma_mask	= ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
 		.port_ops	= &piix_pata_ops,
 	},
-
-	[piix_pata_33] =	/* PIIX4 at 33MHz */
-	{
+	[piix_pata_33] = {	/* PIIX4 at 33MHz */
 		.flags		= PIIX_PATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
-		.mwdma_mask	= ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
+		.mwdma_mask	= ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
 		.udma_mask	= ATA_UDMA2,
 		.port_ops	= &piix_pata_ops,
 	},
-
-	[ich_pata_33] = 	/* ICH0 - ICH at 33Mhz*/
-	{
+	[ich_pata_33] = {	/* ICH0 - ICH at 33Mhz*/
 		.flags		= PIIX_PATA_FLAGS,
-		.pio_mask 	= ATA_PIO4,
-		.mwdma_mask	= ATA_MWDMA12_ONLY, /* Check: maybe MWDMA0 is ok  */
+		.pio_mask	= ATA_PIO4,
+		.mwdma_mask	= ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
 		.udma_mask	= ATA_UDMA2,
 		.port_ops	= &ich_pata_ops,
 	},
-
-	[ich_pata_66] = 	/* ICH controllers up to 66MHz */
-	{
+	[ich_pata_66] = {	/* ICH controllers up to 66MHz */
 		.flags		= PIIX_PATA_FLAGS,
-		.pio_mask 	= ATA_PIO4,
+		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA12_ONLY, /* MWDMA0 is broken on chip */
 		.udma_mask	= ATA_UDMA4,
 		.port_ops	= &ich_pata_ops,
 	},
-
-	[ich_pata_100] =
-	{
+	[ich_pata_100] = {
 		.flags		= PIIX_PATA_FLAGS | PIIX_FLAG_CHECKINTR,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA12_ONLY,
 		.udma_mask	= ATA_UDMA5,
 		.port_ops	= &ich_pata_ops,
 	},
-
-	[ich_pata_100_nomwdma1] =
-	{
+	[ich_pata_100_nomwdma1] = {
 		.flags		= PIIX_PATA_FLAGS | PIIX_FLAG_CHECKINTR,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2_ONLY,
 		.udma_mask	= ATA_UDMA5,
 		.port_ops	= &ich_pata_ops,
 	},
-
-	[ich5_sata] =
-	{
+	[ich5_sata] = {
 		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[ich6_sata] =
-	{
+	[ich6_sata] = {
 		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[ich6m_sata] =
-	{
+	[ich6m_sata] = {
 		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[ich8_sata] =
-	{
+	[ich8_sata] = {
 		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[ich8_2port_sata] =
-	{
+	[ich8_2port_sata] = {
 		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[tolapai_sata] =
-	{
+	[tolapai_sata] = {
 		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[ich8m_apple_sata] =
-	{
+	[ich8m_apple_sata] = {
 		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
 		.mwdma_mask	= ATA_MWDMA2,
 		.udma_mask	= ATA_UDMA6,
 		.port_ops	= &piix_sata_ops,
 	},
-
-	[piix_pata_vmw] =
-	{
+	[piix_pata_vmw] = {
 		.flags		= PIIX_PATA_FLAGS,
 		.pio_mask	= ATA_PIO4,
-		.mwdma_mask	= ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
+		.mwdma_mask	= ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
 		.udma_mask	= ATA_UDMA2,
 		.port_ops	= &piix_vmw_ops,
 	},
-
 };
 
 static struct pci_bits piix_enable_bits[] = {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/