linux-kernel - RE: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6D8AE7E@saturn3.aculab.com>
Date:	Thu, 13 Oct 2011 16:37:20 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Timur Tabi" <timur@...escale.com>,
	"Kumar Gala" <galak@...nel.crashing.org>
Cc:	<linuxppc-dev@...abs.org>, <hjk@...sjkoch.de>, <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>,
	"Jiang Kai-B18973" <B18973@...escale.com>
Subject: RE: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

 
> Kumar Gala wrote:
> >>> >> +       phys_addr_t             addr;
> >> > 
> >> > Please add a comment here saying:
> >> > 
> >> > 1) That 'addr' can be a virtual or physical address
> > The code and everything else makes that clear
> 
> I'm sorry, but I have to strongly disagree here.  It is *NOT* 
> clear that a variable of type 'phys_addr_t' can hold something
> that is not a physical address.

Since there is a discriminating field, could a union be used?
At a guess the type of the address is constrained between
produces and consumer??

	David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/