linux-kernel - Re: [PATCH v2 2/4] ata_piix: unify code for programming PIO and MWDMA timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E98688D.3070505@mvista.com>
Date:	Fri, 14 Oct 2011 20:51:25 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
CC:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] ata_piix: unify code for programming PIO and MWDMA
 timings

Hello.

On 10/14/2011 08:43 PM, Sergei Shtylyov wrote:

>>>> From: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
>>>> Subject: [PATCH v2] ata_piix: unify code for programming PIO and MWDMA timings

>>>> Besides making things noticably simpler it results in ~2% decrease in
>>>> the driver LOC count and also ~2% decrease in the driver binary size
>>>> (as measured on x86-32).

>>>> Fix piix_set_piomode() documentation while at it.

>>>> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>

>>> I'm still inclined to NAK this patch.

>>>> ---
>>>> v2: remove use_mwdma variable and fix comment style

>>>> earlier references:
>>>> https://lkml.org/lkml/2011/2/8/99

>>>> drivers/ata/ata_piix.c | 111 ++++++++++++++++---------------------------------
>>>> 1 file changed, 38 insertions(+), 73 deletions(-)

>>>> Index: b/drivers/ata/ata_piix.c
>>>> ===================================================================
>>>> --- a/drivers/ata/ata_piix.c
>>>> +++ b/drivers/ata/ata_piix.c
[...]

>> We still have following code at the end of piix_set_timings():

>> /* Ensure the UDMA bit is off - it will be turned back on if
>> UDMA is selected */
>>
>> if (ap->udma_mask) {
>> pci_read_config_byte(dev, 0x48,&udma_enable);
>> udma_enable&= ~(1<< (2 * ap->port_no + adev->devno));
>> pci_write_config_byte(dev, 0x48, udma_enable);
>> }

>> so everything should be OK.

> Ah, I should have looked... Didn't expect it to be there, and it in fact
> shouldn't be there, but now I'm OK with your patch. :-)

    But I would have preferred the above code to be removed, of course.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/