[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4E986988.6080106@pobox.com>
Date: Fri, 14 Oct 2011 12:55:36 -0400
From: Jeff Garzik <jgarzik@...ox.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
David Miller <davem@...emloft.net>
CC: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] pata_pcmcia/ide-cs: move IDs table to <linux/pata_pcmcia_ids.h>
On 10/13/2011 07:12 AM, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
> Subject: [PATCH] pata_pcmcia/ide-cs: move IDs table to<linux/pata_pcmcia_ids.h>
>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
> ---
> drivers/ata/pata_pcmcia.c | 74 +---------------------------------------
> drivers/ide/ide-cs.c | 74 +---------------------------------------
> include/linux/pata_pcmcia_ids.h | 70 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 75 insertions(+), 143 deletions(-)
I'm torn... it is an obvious and simple consolidation, but I dislike
dropping such a driver-specific turd in include/linux. I also wonder if
we want to continue adding new IDs to ide-cs?
David, any opinions? I'm basically ok with any option: (a) take Bart's
patch as-is (with your acked-by), (b) ignore the patch and set a
no-new-ids policy for ide-cs, (c) other?
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists